Move core-cli-utils to private/ as a reference implementation (#56922)#56922
Open
huntie wants to merge 1 commit into
Open
Move core-cli-utils to private/ as a reference implementation (#56922)#56922huntie wants to merge 1 commit into
huntie wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105959855. |
meta-codesync
Bot
changed the title
huntie
added a commit
to huntie/react-native
that referenced
this pull request
May 21, 2026
…ok#56922) Summary: Pull Request resolved: facebook#56922 Move `react-native/core-cli-utils` from `packages/` to `private/`, stop publishing it to npm, and reframe it as a reference implementation of React Native CLI tooling. The package has no known external consumers and is only used internally by `private/helloworld/` and `packages/rn-tester/`. Publishing it to npm creates a maintenance surface for a package that serves no external users. See react-native-community/discussions-and-proposals#1002. #### Changes - Move `packages/core-cli-utils/` to `private/core-cli-utils/` - Mark the package as `"private": true`, remove `publishConfig`, `files`, and `prepack` script - Remove from the npm build pipeline (`scripts/build/config.js`) - Remove the defunct `patchCoreCLIUtilsPackageJSON()` runtime patching from both `helloworld/cli.js` and `rn-tester/cli.js`, and delete both `monorepo.js` files that contained it - Add missing `react-native/core-cli-utils` devDependency to `rn-tester/package.json` - Add `core-cli-utils` as a workspace in both `xplat/js/package.json` and `xplat/js/public/package.json` - Remove redundant desktop import ignore entry (`private/**` already covers it) - Rewrite README as reference implementation documentation Changelog: [Internal] Differential Revision: D105959855
huntie
added a commit
to huntie/react-native
that referenced
this pull request
May 21, 2026
…ok#56922) Summary: Pull Request resolved: facebook#56922 Move `react-native/core-cli-utils` from `packages/` to `private/`, stop publishing it to npm, and reframe it as a reference implementation of React Native CLI tooling. The package has no known external consumers and is only used internally by `private/helloworld/` and `packages/rn-tester/`. Publishing it to npm creates a maintenance surface for a package that serves no external users. See react-native-community/discussions-and-proposals#1002. #### Changes - Move `packages/core-cli-utils/` to `private/core-cli-utils/` - Mark the package as `"private": true`, remove `publishConfig`, `files`, and `prepack` script - Remove from the npm build pipeline (`scripts/build/config.js`) - Remove the defunct `patchCoreCLIUtilsPackageJSON()` runtime patching from both `helloworld/cli.js` and `rn-tester/cli.js`, and delete both `monorepo.js` files that contained it - Add missing `react-native/core-cli-utils` devDependency to `rn-tester/package.json` - Add `core-cli-utils` as a workspace in both `xplat/js/package.json` and `xplat/js/public/package.json` - Remove redundant desktop import ignore entry (`private/**` already covers it) - Rewrite README as reference implementation documentation Changelog: [Internal] Differential Revision: D105959855
huntie
added a commit
to huntie/react-native
that referenced
this pull request
May 21, 2026
…ok#56922) Summary: Pull Request resolved: facebook#56922 Move `react-native/core-cli-utils` from `packages/` to `private/`, stop publishing it to npm, and reframe it as a reference implementation of React Native CLI tooling. The package has no known external consumers and is only used internally by `private/helloworld/` and `packages/rn-tester/`. Publishing it to npm creates a maintenance surface for a package that serves no external users. See react-native-community/discussions-and-proposals#1002. #### Changes - Move `packages/core-cli-utils/` to `private/core-cli-utils/` - Mark the package as `"private": true`, remove `publishConfig`, `files`, and `prepack` script - Remove from the npm build pipeline (`scripts/build/config.js`) - Remove the defunct `patchCoreCLIUtilsPackageJSON()` runtime patching from both `helloworld/cli.js` and `rn-tester/cli.js`, and delete both `monorepo.js` files that contained it - Add missing `react-native/core-cli-utils` devDependency to `rn-tester/package.json` - Add `core-cli-utils` as a workspace in both `xplat/js/package.json` and `xplat/js/public/package.json` - Remove redundant desktop import ignore entry (`private/**` already covers it) - Rewrite README as reference implementation documentation Changelog: [Internal] Differential Revision: D105959855
huntie
added a commit
to huntie/react-native
that referenced
this pull request
May 21, 2026
…ok#56922) Summary: Pull Request resolved: facebook#56922 Move `react-native/core-cli-utils` from `packages/` to `private/`, stop publishing it to npm, and reframe it as a reference implementation of React Native CLI tooling. The package has no known external consumers and is only used internally by `private/helloworld/` and `packages/rn-tester/`. Publishing it to npm creates a maintenance surface for a package that serves no external users. See react-native-community/discussions-and-proposals#1002. #### Changes - Move `packages/core-cli-utils/` to `private/core-cli-utils/` - Mark the package as `"private": true`, remove `publishConfig`, `files`, and `prepack` script - Remove from the npm build pipeline (`scripts/build/config.js`) - Remove the defunct `patchCoreCLIUtilsPackageJSON()` runtime patching from both `helloworld/cli.js` and `rn-tester/cli.js`, and delete both `monorepo.js` files that contained it - Add missing `react-native/core-cli-utils` devDependency to `rn-tester/package.json` - Add `core-cli-utils` as a workspace in both `xplat/js/package.json` and `xplat/js/public/package.json` - Remove redundant desktop import ignore entry (`private/**` already covers it) - Rewrite README as reference implementation documentation Changelog: [Internal] Differential Revision: D105959855
huntie
force-pushed
the
export-D105959855
branch
2 times, most recently
from
d3d8c59 to
46da633
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
May 21, 2026
…ok#56922) Summary: Pull Request resolved: facebook#56922 Move `react-native/core-cli-utils` from `packages/` to `private/`, stop publishing it to npm, and reframe it as a reference implementation of React Native CLI tooling. The package has no known external consumers and is only used internally by `private/helloworld/` and `packages/rn-tester/`. Publishing it to npm creates a maintenance surface for a package that serves no external users. See react-native-community/discussions-and-proposals#1002. #### Changes - Move `packages/core-cli-utils/` to `private/core-cli-utils/` - Mark the package as `"private": true`, remove `publishConfig`, `files`, and `prepack` script - Remove from the npm build pipeline (`scripts/build/config.js`) - Remove the defunct `patchCoreCLIUtilsPackageJSON()` runtime patching from both `helloworld/cli.js` and `rn-tester/cli.js`, and delete both `monorepo.js` files that contained it - Add missing `react-native/core-cli-utils` devDependency to `rn-tester/package.json` - Add `core-cli-utils` as a workspace in both `xplat/js/package.json` and `xplat/js/public/package.json` - Remove redundant desktop import ignore entry (`private/**` already covers it) - Rewrite README as reference implementation documentation Changelog: [General][Breaking] - The `react-native/core-cli-utils` package is no longer published. It remains available in the React Native repo as a reference implementation. Differential Revision: D105959855
huntie
added a commit
to huntie/react-native
that referenced
this pull request
May 22, 2026
…ok#56922) Summary: Pull Request resolved: facebook#56922 Move `react-native/core-cli-utils` from `packages/` to `private/`, stop publishing it to npm, and reframe it as a reference implementation of React Native CLI tooling. The package has no known external consumers and is only used internally by `private/helloworld/` and `packages/rn-tester/`. Publishing it to npm creates a maintenance surface for a package that serves no external users. See react-native-community/discussions-and-proposals#1002. #### Changes - Move `packages/core-cli-utils/` to `private/core-cli-utils/`. - Convert all source files to CJS (require/module.exports) with Flow comment syntax (/*:: */), eliminating the runtime Babel dependency. - Remove from the JS build pipeline (`scripts/build/config.js`). - Remove the defunct `patchCoreCLIUtilsPackageJSON()` runtime patching from both `helloworld/cli.js` and `rn-tester/cli.js`, and delete both `monorepo.js` files that contained it. - Add as `devDependency` to `rn-tester` and `helloworld`. - Skip `"*"` version deps in `_prepareHelloWorld()` so they aren't rewritten to the Verdaccio-published version. - Remove redundant desktop import ignore entry (`private/**` already covers it). - Rewrite README as reference implementation documentation. Changelog: [General][Breaking] - The `react-native/core-cli-utils` package is no longer published. It remains available in the React Native repo as a reference implementation. Differential Revision: D105959855
…ok#56922) Summary: Pull Request resolved: facebook#56922 Move `react-native/core-cli-utils` from `packages/` to `private/`, stop publishing it to npm, and reframe it as a reference implementation of React Native CLI tooling. The package has no known external consumers and is only used internally by `private/helloworld/` and `packages/rn-tester/`. Publishing it to npm creates a maintenance surface for a package that serves no external users. See react-native-community/discussions-and-proposals#1002. #### Changes - Move `packages/core-cli-utils/` to `private/core-cli-utils/`. - Convert all source files to CJS (require/module.exports) with Flow comment syntax (/*:: */), eliminating the runtime Babel dependency. - Remove from the JS build pipeline (`scripts/build/config.js`). - Remove the defunct `patchCoreCLIUtilsPackageJSON()` runtime patching from both `helloworld/cli.js` and `rn-tester/cli.js`, and delete both `monorepo.js` files that contained it. - Add as `devDependency` to `rn-tester` and `helloworld`. - Skip `"*"` version deps in `_prepareHelloWorld()` so they aren't rewritten to the Verdaccio-published version. - Remove redundant desktop import ignore entry (`private/**` already covers it). - Rewrite README as reference implementation documentation. Changelog: [General][Breaking] - The `react-native/core-cli-utils` package is no longer published. It remains available in the React Native repo as a reference implementation. Differential Revision: D105959855
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Move
react-native/core-cli-utilsfrompackages/toprivate/, stop publishing it to npm, and reframe it as a reference implementation of React Native CLI tooling.The package has no known external consumers and is only used internally by
private/helloworld/andpackages/rn-tester/. Publishing it to npm creates a maintenance surface for a package that serves no external users.See react-native-community/discussions-and-proposals#1002.
Changes
packages/core-cli-utils/toprivate/core-cli-utils/.scripts/build/config.js).patchCoreCLIUtilsPackageJSON()runtime patching from bothhelloworld/cli.jsandrn-tester/cli.js, and delete bothmonorepo.jsfiles that contained it.devDependencytorn-testerandhelloworld."*"version deps in_prepareHelloWorld()so they aren't rewritten to the Verdaccio-published version.private/**already covers it).Changelog:
[General][Breaking] - The
react-native/core-cli-utilspackage is no longer published. It remains available in the React Native repo as a reference implementation.Differential Revision: D105959855